CORS-4529: Azure IL6 Secret Cloud support - #2919
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Hello @jhixson74! Some important instructions when contributing to openshift/api: |
|
@jhixson74: This pull request references CORS-4259 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.0." or "openshift-5.0.", but it targets "4.21.0" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (41)
📒 Files selected for processing (15)
🚧 Files skipped from review as they are similar to previous changes (13)
📝 WalkthroughWalkthroughThe Azure cloud environment validation now accepts Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented Comment |
|
@jhixson74: This pull request references CORS-4529 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@jhixson74: This pull request references CORS-4529 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
Scheduling tests matching the |
|
/retest |
|
Is there any extended testing or anything needed for this environment or is this really just updating the enum and done? |
I am not sure what is being asked here. I am not aware of anything else needing work here. The enum if required for the rest of the work I am doing. Any and all testing will be taking place in other repositories. |
57814bd to
f8f460f
Compare
f8f460f to
4d03370
Compare
|
/lgtm |
|
Scheduling tests matching the |
- Add Azure Government Secret IL6 Cloud as a valid Azure cloud environment.
4d03370 to
ec17675
Compare
|
/lgtm |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| // AzureCloudEnvironment is the name of the Azure cloud environment | ||
| // +kubebuilder:validation:Enum="";AzurePublicCloud;AzureUSGovernmentCloud;AzureChinaCloud;AzureGermanCloud;AzureStackCloud | ||
| // +kubebuilder:validation:Enum="";AzurePublicCloud;AzureUSGovernmentCloud;AzureChinaCloud;AzureGermanCloud;AzureStackCloud;AzureUSSecCloud |
There was a problem hiding this comment.
I understand that AzureCloudEnvironment enum has existed for a while. Technically, https://github.com/openshift/api/blame/master/config/v1/types_infrastructure.go#L658-L662 should not be allowed to change on day-2. There is no kubebuilder validation for that.
|
/pipeline required |
|
Scheduling tests matching the |
|
/verified later |
|
@sadasu: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified later @jhixson74 |
|
@sadasu: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@JoelSpeed It is being tested on a special emulator environment. |
|
@everettraven |
|
/override ci/prow/verify-hypershift-integration |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-hypershift-integration DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jhixson74: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold Revision ec17675 was retested 3 times: holding |
Add Azure Government Secret IL6 Cloud as a valid Azure cloud environment